replace getWindowDisplayMetrics with getScreenDisplayMetrics#53041
Closed
alanleedev wants to merge 1 commit into
Closed
replace getWindowDisplayMetrics with getScreenDisplayMetrics#53041alanleedev wants to merge 1 commit into
alanleedev wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79571226 |
alanleedev
force-pushed
the
export-D79571226
branch
from
0c45229 to
f3e5605
Compare
…k#53041) Summary: Pull Request resolved: facebook#53041 update `DisplayMetricsHolder.getWindowDisplayMetrics()` to `getScreenDisplayMetrics()`. Where window width and height is not needed, prefer to use `screenDisplayMetrics` as with upcoming diff `windowDisplayMetrics` initialization only happen using UiContext and have potential to cause more issues if used unnecessarily. Changelog: [Internal] Update `DisplayMetricsHolder.getWindowDisplayMetrics()` to use `.getScreenDisplayMetrics()` Reviewed By: mlord93 Differential Revision: D79571226
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79571226 |
alanleedev
force-pushed
the
export-D79571226
branch
from
f3e5605 to
bb74cb4
Compare
Contributor
|
This pull request has been merged in 8b2e309. |
Collaborator
|
This pull request was successfully merged by @alanleedev in 8b2e309 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been reverted by f21a890. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
update
DisplayMetricsHolder.getWindowDisplayMetrics()togetScreenDisplayMetrics().Where window width and height is not needed, prefer to use
screenDisplayMetricsas with upcoming diffwindowDisplayMetricsinitialization only happen using UiContext and have potential to cause more issues if used unnecessarily.Changelog: [Internal] Update
DisplayMetricsHolder.getWindowDisplayMetrics()to use.getScreenDisplayMetrics()Differential Revision: D79571226